runtime: single source of truth for embedded Node path/version#146
Merged
benvinegar merged 2 commits intomainfrom Feb 23, 2026
Merged
runtime: single source of truth for embedded Node path/version#146benvinegar merged 2 commits intomainfrom
benvinegar merged 2 commits intomainfrom
Conversation
Greptile SummaryCentralizes embedded Node.js runtime path resolution by introducing Key improvements:
Confidence Score: 5/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[bin/lib/runtime-node.sh] -->|sources| B[setup.sh]
A -->|sources| C[bin/baudbot]
A -->|sources| D[start.sh]
A -->|sources| E[bin/doctor.sh]
A -->|sources| F[bin/lib/baudbot-runtime.sh]
A -->|sources| G[bin/security-audit.sh]
B -->|creates symlink| H[~/opt/node -> ~/opt/node-v22.14.0-linux-x64]
B -->|uses| I[bb_runtime_node_version]
B -->|uses| J[bb_runtime_node_bin_dir]
C -->|preserves| K[BAUDBOT_RUNTIME_NODE_VERSION]
C -->|calls| L[bb_resolve_runtime_node_bin]
D -->|calls| M[bb_resolve_runtime_node_bin_dir]
E -->|calls| L
E -->|checks| N[runtime path drift]
O[bin/runtime-node-paths.test.sh] -->|prevents| P[hardcoded versioned paths]
O -->|integrated in| Q[test/shell-scripts.test.mjs]
R[install.sh] -->|passes env to| B
S[bin/deploy.sh] -->|deploys| A
S -->|to| T[~/runtime/bin/lib/runtime-node.sh]
Last reviewed commit: ede5635 |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
benvinegar
force-pushed
the
runtime/node-source-of-truth-115
branch
from
ede5635 to
22d2177
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #115 by removing hardcoded embedded Node version paths and introducing a canonical runtime locator with compatibility fallbacks.
What changed
bin/lib/runtime-node.shas the single source for embedded Node resolution22.14.0BAUDBOT_RUNTIME_NODE_VERSION~/opt/node/bin~/opt/node-v*-linux-x64/bin/nodeinstallssetup.shnow sources runtime helper and creates stable symlink~/opt/node -> ~/opt/node-v<version>-linux-x64install.sh+bin/baudbotnow pass/preserveBAUDBOT_RUNTIME_NODE_VERSIONstart.sh,bin/doctor.sh,bin/security-audit.sh,bin/baudbot,bin/lib/baudbot-runtime.sh,bin/baudbot.servicebin/ci/setup-ubuntu.sh,bin/ci/setup-arch.shpi/skills/control-agent/SKILL.md,pi/skills/control-agent/startup-cleanup.shbin/runtime-node-paths.test.shfails on versioned path literals (node-vX.Y.Z-linux-x64)test/shell-scripts.test.mjsbin/doctor.shnow reports path driftCONFIGURATION.md) withBAUDBOT_RUNTIME_NODE_VERSIONbin/lib/runtime-node.shin runtime (~/runtime/bin/lib/runtime-node.sh)Validation
npm run test:shell✅DO_API_TOKEN) and CI scripts:bin/ci/setup-ubuntu.sh) ✅bin/ci/setup-arch.sh) ✅bin/test.shsuites successfullyCloses #115